smp agent: handle client/agent version downgrades after connection was established#1508
Merged
Conversation
epoberezkin
commented
Apr 10, 2025
| parseMessage msgBody | ||
| clientVRange <- asks $ smpClientVRange . config | ||
| unless (phVer `isCompatible` clientVRange) . throwE $ AGENT A_VERSION | ||
| unless (phVer `isCompatible` clientVRange || phVer <= agreedClientVerion) . throwE $ AGENT A_VERSION |
Member
Author
There was a problem hiding this comment.
this fixes downgrade for established connections
epoberezkin
commented
Apr 10, 2025
| unless | ||
| (agentVersion `isCompatible` smpAgentVRange && smpClientVersion `isCompatible` smpClientVRange) | ||
| (throwE $ AGENT A_VERSION) | ||
| -- checking agreed versions to continue connection in case of client/agent version downgrades |
Member
Author
There was a problem hiding this comment.
this fixes downgrade during connection handshake
epoberezkin
force-pushed
the
ep/handle-agent-downgrade
branch
from
c762fd2 to
c95a405
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.